Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/client-unittest.cc File src/kudu/client/client-unittest.cc: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/client-unittest.cc@267 PS19, Line 267: Could you also add a scenario where a schema with a INT64 column named "auto_incrementing_id" is created and added into the list of non-unique primary key columns? What's the expected behavior of the client library in that case? http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.h@798 PS19, Line 798: Utility function to return the actual name of the auto incrementing column > Java client don't allow to use Alter Table API to rename or drop the auto-i Yep, that makes sense. Do we want to restrict DDL operations with the auto-incrementing column at the server side as well? Or we rather want to have this only as the client-side restriction since there isn't any inconsistencies from the server-side point of view if renaming and the auto-incrementing column? I guess we should at least restrict dropping the auto-incrementing column at the server side since the column is a part of the primary key, and Kudu doesn't properly handle update of the primary key columns as well as columns participating in partition schema. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 19 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 18 Jan 2023 02:16:17 +0000 Gerrit-HasComments: Yes
