Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.h@798 PS19, Line 798: Utility function to return the actual name of the auto incrementing column > Yep, that makes sense. Do we want to restrict DDL operations with the auto Yes, there will be a followup patch on the server side to restrict alter table operations involving auto-incrementing column. For the C++ client side changes, I think Marton was planning to include those changes in the followup changelist along with the server side bits. http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.cc@589 PS19, Line 589: std::string Name; : KuduColumnSchema::DataType Type; > style nit: the name of these fields should start with non-capital letters +1 -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 19 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 18 Jan 2023 04:30:30 +0000 Gerrit-HasComments: Yes
