Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 25: (2 comments) http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/session-internal.cc@375 PS24, Line 375: > nit: ... this type of write operation ... Done. Yes, this is an example message which would be displayed: "Illegal state: this type of write operation is not supported on table with auto-incrementing column: UPSERT int32 key=1" http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/table_alterer-internal.cc File src/kudu/client/table_alterer-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/table_alterer-internal.cc@116 PS24, Line 116: add a column with > nit: ... a column with reserved name Done -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 25 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:31:52 +0000 Gerrit-HasComments: Yes
