Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 24: Code-Review+2 (5 comments) Overall looks good to me! Just a couple of nits in the error messages to make them less surprising, if they are ever read by humans :) http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.h@798 PS19, Line 798: @note The new row refers to this KuduSchema object, so it must be > Since this came up during review, I took some time to add restrictions to t That's great. Thanks a lot! http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/schema.cc@589 PS19, Line 589: } : > Done x3. Yes, that change makes sense to me. And the new place to keep that constant looks like a better option. Thanks! http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/session-internal.cc@375 PS24, Line 375: write operation nit: ... this type of write operation ... And op.ToString() should contain the information on the op's type, right? http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/table_alterer-internal.cc File src/kudu/client/table_alterer-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/24/src/kudu/client/table_alterer-internal.cc@116 PS24, Line 116: add reserved name nit: ... a column with reserved name http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/common/schema.cc@a293 PS19, Line 293: : : : : : : : : : : : > Thinking more about it, yes I think it makes sense. Cool, thanks! -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 24 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 26 Jan 2023 04:56:04 +0000 Gerrit-HasComments: Yes
