Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19451 )
Change subject: [KUDU-3438] TabletCopyClientAbortTest maybe core ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19451/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19451/1//COMMIT_MSG@14 PS1, Line 14: It is better to Add NO_FATALS() for TabletCopyClientTest::SetUp() : to avoid nullptr TabletCopyClient. If TabletCopyClientTest::SetUp() failed, it will fail and exit itself, why need wrap another NO_FATALS() ? -- To view, visit http://gerrit.cloudera.org:8080/19451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1eeea183bf9fc0b566e6a70f2f7520f34b2ae3c Gerrit-Change-Number: 19451 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 30 Jan 2023 02:39:46 +0000 Gerrit-HasComments: Yes
