Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19451 )
Change subject: [KUDU-3438] TabletCopyClientAbortTest maybe core ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Thank you for the fix! A few nits in the commit description, otherwise looks good. http://gerrit.cloudera.org:8080/#/c/19451/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19451/3//COMMIT_MSG@7 PS3, Line 7: maybe core nit: might crash Whether a core is generated or not depends on particular OS-level setting, but certainly the test crashes with SIGSEGV under such conditions. http://gerrit.cloudera.org:8080/#/c/19451/3//COMMIT_MSG@12 PS3, Line 12: coredump nit: a crash http://gerrit.cloudera.org:8080/#/c/19451/3//COMMIT_MSG@14 PS3, Line 14: It is better to Add NO_FATALS() for TabletCopyClientTest::SetUp() : to avoid nullptr TabletCopyClient. > I see there is already a NO_FATALS in https://github.com/apache/kudu/blob/5 Right, but I guess that leads only to exiting earlier from TabletCopyClientTest::SetUp() when an error occurs in TabletCopyTest::SetUp(). Here we also want to exit earlier from TabletCopyClientAbortTest::SetUp() upon the very first error in TabletCopyClientTest::SetUp(). -- To view, visit http://gerrit.cloudera.org:8080/19451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1eeea183bf9fc0b566e6a70f2f7520f34b2ae3c Gerrit-Change-Number: 19451 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 01 Feb 2023 20:04:28 +0000 Gerrit-HasComments: Yes
