Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 )
Change subject: jwt: expose MiniOidc to Kudu test binary ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@75 PS6, Line 75: invalid_key It's better to keep consistent with CreateJwtPB to name it as valid_key? http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: valid_key It's better to rename as valid_key_id -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 06 Feb 2023 22:03:17 +0000 Gerrit-HasComments: Yes
