Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 )
Change subject: jwt: expose MiniOidc to Kudu test binary ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@75 PS6, Line 75: invalid_key > +1 Done http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: valid_key > Maybe, keep this consistent with naming of other boolean fields in the file This determines if the returned token will be valid or not. This is controlled by placing the id of a valid or an invalid key into the token. So the returned value will still be a token. I think changing it to is_valid_key works the best. But it also could be simply is_valid I guess. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 09 Feb 2023 15:26:50 +0000 Gerrit-HasComments: Yes
