Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19478 )
Change subject: [clock] output more info in SystemNtp::DumpDiagnostics() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Looks good to me. http://gerrit.cloudera.org:8080/#/c/19478/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19478/2//COMMIT_MSG@16 PS2, Line 16: As already mentioned, this patch also adds a new 'clock_ntp_status' : metric that provides information on ntp_gettime()/ntp_adjtime() call : result. It's a string containing current timestamp (usec), : max error (usec), and the result status of the call. nit: Is it possible to show that output somewhere here or upload the file that contains the output ? -- To view, visit http://gerrit.cloudera.org:8080/19478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb74e81ba1e4bc4c60acc6bd49bb458085e28207 Gerrit-Change-Number: 19478 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 14:49:45 +0000 Gerrit-HasComments: Yes
