Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19478 )
Change subject: [clock] output more info in SystemNtp::DumpDiagnostics() ...................................................................... [clock] output more info in SystemNtp::DumpDiagnostics() This patch adds more details to the output of the DumpDiagnostics() method for the system clock synchronized with NTP. In particular, the output now contains relevant metrics for the hybrid clock, the output of the 'ntpstat' utility (if present), the output of 'chronyc activity' (if the 'chronyc' CLI is present), and a snapshot of the newly introduced 'clock_ntp_status' metric. As already mentioned, this patch also adds a new 'clock_ntp_status' metric that provides information on ntp_gettime()/ntp_adjtime() call result. It's a string containing current timestamp (usec), max error (usec), and the result status of the call. The corresponding HybridClockTest.TestNtpDiagnostics scenario has been updated correspondingly. Change-Id: Ibb74e81ba1e4bc4c60acc6bd49bb458085e28207 Reviewed-on: http://gerrit.cloudera.org:8080/19478 Tested-by: Kudu Jenkins Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/clock/hybrid_clock-test.cc M src/kudu/clock/hybrid_clock.cc M src/kudu/clock/system_ntp.cc M src/kudu/clock/system_ntp.h 4 files changed, 99 insertions(+), 4 deletions(-) Approvals: Kudu Jenkins: Verified Ashwani Raina: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibb74e81ba1e4bc4c60acc6bd49bb458085e28207 Gerrit-Change-Number: 19478 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
