Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add query id to trace the whole query process ...................................................................... Patch Set 31: Verified+1 (1 comment) Unrelated test failure (ASAN) http://gerrit.cloudera.org:8080/#/c/18846/27/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18846/27/src/kudu/client/client.cc@2019 PS27, Line 2019: } : : VLOG(2) << "Beginning " << data_->DebugString(); : > Sorry. I maybe not understand what you mean exactly. Could you give more de The question was: does it makes sense to make this behavior (i.e. whether to auto-generate query id) configurable. After looking at this one more time, I think there isn't a need to toggle this query id generation on/off since it's quite cheap, and it doesn't hurt adding to each scanner. Yep -- it would be great if you can update the Java client to have similar functionality as you just introduced in this patch in C++ client. Thanks a lot! -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 31 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 17 Feb 2023 23:31:34 +0000 Gerrit-HasComments: Yes
