KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG@13 PS3, Line 13: table id tablet id? http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h File src/kudu/client/tablet-internal.h: http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h@31 PS3, Line 31: Data > The variables' initialize order in construct function show be same as the o +1 http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.cc File src/kudu/client/tablet-internal.cc: http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.cc@37 PS3, Line 37: KuduTablet::Data::Data(string id, vector<const KuduReplica*> replicas, : string table_id, string table_name) : : id_(std::move(id)), : replicas_(std::move(replicas)), : table_id_(std::move(table_id)), : table_name_(std::move(table_name)) The initialization order should correspond to the declaration order. http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448 PS3, Line 448: optional bytes table_id = 8 Why do we need to assign values from 8? -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 12:28:14 +0000 Gerrit-HasComments: Yes
