Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG@13 PS3, Line 13: tablet i > tablet id? Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/client.h@1180 PS3, Line 1180: const std::string& id() const; : > I don't think these new methods are needed in the public client API if only Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h File src/kudu/client/tablet-internal.h: http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h@31 PS3, Line 31: Data > +1 Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto File src/kudu/master/master.proto: PS3: > The newly added fields TabletLocationsPB::table_id and TabletLocationsPB::t Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448 PS3, Line 448: // DEPRECATED. > Why do we need to assign values from 8? The field interned_replicas is 7. http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448 PS3, Line 448: // DEPRECATED. : // Used only if interned replic > Whether is it necessary to move them to the end? Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@295 PS3, Line 295: K(CreateKudu > 'FLAGS_format' has many values as below. Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@321 PS3, Line 321: cerr << "Replaced tablet " << tablet_id << " with tablet "; > nit: remote an empty line Done http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409 PS3, Line 409: ilable.\n > Alternatively, it could be just 'info'? Done -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 01 Mar 2023 09:59:39 +0000 Gerrit-HasComments: Yes
