Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable ...................................................................... [fs] make CommitDeletedBlocks output parameter nullable The output parameter of BlockDeletionTransaction::CommitDeletedBlocks 'deleted' is useless in some cases, it could be set to nullptr to reduce minor filling of the container. This patch also fixes some issues reported by clang-tidy. Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6 Reviewed-on: http://gerrit.cloudera.org:8080/19520 Reviewed-by: Yifan Zhang <[email protected]> Reviewed-by: Yuqi Du <[email protected]> Reviewed-by: Ashwani Raina <[email protected]> Tested-by: Yingchun Lai <[email protected]> --- M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/tablet/tablet_metadata.cc 7 files changed, 90 insertions(+), 83 deletions(-) Approvals: Yifan Zhang: Looks good to me, approved Yuqi Du: Looks good to me, but someone else must approve Ashwani Raina: Looks good to me, but someone else must approve Yingchun Lai: Verified -- To view, visit http://gerrit.cloudera.org:8080/19520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6 Gerrit-Change-Number: 19520 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
