Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19520 )
Change subject: [fs] make CommitDeletedBlocks output parameter nullable ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/19520/9/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19520/9/src/kudu/fs/file_block_manager.cc@236 PS9, Line 236: FileWritableBlock final > I am little unclear on this. Are you making this class "underivable from"? It's a simple way to mute complains from Tidy Bot like https://gerrit.cloudera.org/c/19520/1/src/kudu/fs/file_block_manager.cc#310. Otherwise, we have to write more confused code (like calling `FileWritableBlock::Abort()`, `FileWritableBlock::id()` in ~FileWritableBlock()) -- To view, visit http://gerrit.cloudera.org:8080/19520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92c36011cf8fc63d58fad7da0e08554b9d5dad6 Gerrit-Change-Number: 19520 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 16:13:14 +0000 Gerrit-HasComments: Yes
