KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19519 )
Change subject: [LBM] append CREATE/DELETE records in batch to metadata ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/19519/9/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19519/9/src/kudu/fs/log_block_manager.cc@2743 PS9, Line 2743: continue; There are no errors here. I just want to know whether we have a corresponding mechanism to deal with this special situation if only part of the blocks are successfully updated here? http://gerrit.cloudera.org:8080/#/c/19519/9/src/kudu/fs/log_block_manager.cc@2756 PS9, Line 2756: log_blocks->insert(log_blocks->end(), : lbs_by_container.second.begin(), : lbs_by_container.second.end()) Should we add successful blocks instead of recording them after all the blocks corresponding to the container have been successfully appened? -- To view, visit http://gerrit.cloudera.org:8080/19519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie24adab3b1dbbea55108a1f525093136fcf5a726 Gerrit-Change-Number: 19519 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 01 Mar 2023 11:54:15 +0000 Gerrit-HasComments: Yes
