Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19519 )
Change subject: [LBM] append CREATE/DELETE records in batch to metadata ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/19519/9/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19519/9/src/kudu/fs/log_block_manager.cc@2743 PS9, Line 2743: // TODO(KUD > There are no errors here. I just want to know whether we have a correspondi If the batch returned here, there are 3 states of the blocks depend on whether their DELETE entries have been wrriten to the container's metadata or not: 1. write succeed: there will be some garbage blocks in .data file because skipped to add them to 'log_blocks' below. 2. write failed: called 'orphaned blocks', can be GCed by 'kudu fs check --repair' offline, but can not be GCed online as mentioned in L2738(KUDU-829). 3. skipped in AppendMetadataForDeleteRecords because of short returned: same to 2 I will fix #1 in next patch set. IMO, #3 is not very reasonable to solve, how can it happen when append a record to .metadata file failed, but append another one success in the same file at the same offset. Are you interested to solve #2? http://gerrit.cloudera.org:8080/#/c/19519/9/src/kudu/fs/log_block_manager.cc@2756 PS9, Line 2756: container->ExecClosure([self]() { self->CompactMetadata(); }); : } : } > Should we add successful blocks instead of recording them after all the blo Thanks to point it out, same to #1 above, I'll fix it. -- To view, visit http://gerrit.cloudera.org:8080/19519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie24adab3b1dbbea55108a1f525093136fcf5a726 Gerrit-Change-Number: 19519 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 01 Mar 2023 15:27:41 +0000 Gerrit-HasComments: Yes
