Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/19575 )
Change subject: [tools] exit gracefully on errors during table copying
......................................................................
[tools] exit gracefully on errors during table copying
Prior to this patch, an error to write a batch of rows into the
destination table would lead to a crash while running `kudu table copy`
CLI tool. In addition, the information on errors would not be printed
because CheckPendingErrors() was called before Session::Flush().
This patch updates addresses these issues:
* no crashes for non-OK status within TableScanner::CopyTask()
* information on errors encountered during Session::Flush()
is printed into the output stream
This is a follow-up to 28f8e972fcd042a26a502cbb1f1102c487c9398d.
Change-Id: I90dc29b5a3fb8334ec1f54425b84d13faeb19cd5
Reviewed-on: http://gerrit.cloudera.org:8080/19575
Reviewed-by: Yingchun Lai <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
---
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
2 files changed, 50 insertions(+), 32 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90dc29b5a3fb8334ec1f54425b84d13faeb19cd5
Gerrit-Change-Number: 19575
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
