Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19585 )
Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG@9 PS3, Line 9: empty local directories Why a new master joins the cluster, it will execute Master::Init() twice? Cloud you give more detail? http://gerrit.cloudera.org:8080/#/c/19585/3/src/kudu/master/master_options.cc File src/kudu/master/master_options.cc: http://gerrit.cloudera.org:8080/#/c/19585/3/src/kudu/master/master_options.cc@43 PS3, Line 43: : block_cache_metrics_policy_(Cache::ExistingMetricsPolicy::kReset) { Maybe it needs a unit test to prove this modification available. Or a related unit test has exited already. -- To view, visit http://gerrit.cloudera.org:8080/19585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc32d7ab02201382debcbe36311579550353bf71 Gerrit-Change-Number: 19585 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Wed, 08 Mar 2023 09:49:50 +0000 Gerrit-HasComments: Yes
