Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19585 )

Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG@9
PS3, Line 9: empty local directories
> You are correct, A,B,C are not restarted. You can see the exact commands in
Ok, My advice is don't change the default value. I am afraid that it may cause 
some other problems.
You can change the opt at

add 
'opts.set_block_cache_metrics_policy(Cache::ExistingMetricsPolicy::kReset);' 
before the second new Master' opt.

like this:

master_runner.cc:
`
    RETURN_NOT_OK(ClearLocalSystemCatalogAndCopy(leader_hp));
    opts.set_block_cache_metrics_policy(Cache::ExistingMetricsPolicy::kReset);
    server.reset(new Master(opts));
`

By the way, currently, kudu-masters have no way  'membership change 
automatically'.  If D can start normally, then you should also op A B C add D 
to their cmeta file and restart it to load their raft group membership.
The process need an administrator. The administrator just like a coordinator do 
this.

Of course, you can add this logic codes  into kudu-masters. Add a member, 
remove a member, replace a exist member, some situations its useful, and at the 
same. time administrators always needed.



--
To view, visit http://gerrit.cloudera.org:8080/19585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc32d7ab02201382debcbe36311579550353bf71
Gerrit-Change-Number: 19585
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Tue, 28 Mar 2023 04:28:12 +0000
Gerrit-HasComments: Yes

Reply via email to