Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19611 )
Change subject: [ut] make a checking command of 'TestTServerListState' more meaningful ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19611/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19611/3/src/kudu/tools/kudu-tool-test.cc@4889 PS3, Line 4889: ,state I guess the previous purpose is check the 'state' column should not apear if not request, of course it can be covered by ToolTest.TestTserverList. To improve the test, would it better to run the command once, then use ASSERT_STR_NOT_CONTAINS to check ts_uuid_noop and use ASSERT_STR_CONTAINS to check ts_uuid together? -- To view, visit http://gerrit.cloudera.org:8080/19611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc3c16cba812eaaa8786cea37659fd5e9267fd3 Gerrit-Change-Number: 19611 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 14 Mar 2023 03:52:13 +0000 Gerrit-HasComments: Yes
