KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19611 )
Change subject: [ut] make a checking command of 'TestTServerListState' more meaningful ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19611/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19611/4/src/kudu/tools/kudu-tool-test.cc@4891 PS4, Line 4891: ASSERT_STR_NOT_CONTAINS(out, Substitute("$0,$1", ts_uuid_noop, "MAINTENANCE_MODE")); If we set the ts number for 3 in line 4876, how about add a loop check in here, and exclude the node that executed the 'enter_maintenance' command which is cluster_->tablet_server(0). -- To view, visit http://gerrit.cloudera.org:8080/19611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc3c16cba812eaaa8786cea37659fd5e9267fd3 Gerrit-Change-Number: 19611 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 14 Mar 2023 12:00:02 +0000 Gerrit-HasComments: Yes
