Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19445 )
Change subject: [WIP]KUDU-1945 Update auto incrementing counter during bootstrap ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/19445/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19445/1//COMMIT_MSG@28 PS1, Line 28: > It's nice to attach a tested metrics. Thanks Yes, will add in the next patch. http://gerrit.cloudera.org:8080/#/c/19445/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19445/2//COMMIT_MSG@14 PS2, Line 14: In this scenario the WAL segments are replayed and since each insert : operation entry has auto incrementing counter which will be used for : the insert operations present in that entry, as long as we have the : latest insert operation entry in the WAL segments, the auto : incrementing counter is populated correctly during bootstrap. > Just wanted to make sure: is that working as expected when WAL contains non Yes, it is but I will have a test case to cover this situation regardless. http://gerrit.cloudera.org:8080/#/c/19445/2//COMMIT_MSG@20 PS2, Line 20: 2. WAL segments do not contain insert operations : In the case, we need to fetch the highest auto incrementing counter : value present in the data which is already flushed and update the : in memory auto incrementing counter appropriately. This patch : accomplishes this task. > What if current snapshot of the data in the tablet doesn't have a single ro Yes, in that case the counter starts from 1. I don't see any complications arising then. http://gerrit.cloudera.org:8080/#/c/19445/2//COMMIT_MSG@25 PS2, Line 25: Change-Id: I61b305efd7d5a065a2 > It would be great to add test coverage to make sure this works as expected Those test cases will be added. Just for this initial draft these were not included. http://gerrit.cloudera.org:8080/#/c/19445/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19445/2/src/kudu/tablet/tablet.cc@433 PS2, Line 433: pdate the auto incrementing count > Would be great to add a comment why this is safe to look just at the curren We would not allow for adding or dropping of the auto incrementing column. Hence this should be fine. http://gerrit.cloudera.org:8080/#/c/19445/2/src/kudu/tablet/tablet.cc@440 PS2, Line 440: t->NewRow > Could you add a comment to explain why 32K is used here for the row block m Done http://gerrit.cloudera.org:8080/#/c/19445/2/src/kudu/tablet/tablet.cc@449 PS2, Line 449: > nit: drop the space ? Done http://gerrit.cloudera.org:8080/#/c/19445/2/src/kudu/tablet/tablet.cc@453 PS2, Line 453: if (counter > auto_incrementing_counter_) { > I think this might look confusing. First, there might be be multiple diskr This will be dropped. Was just set for my manual testing purposes. -- To view, visit http://gerrit.cloudera.org:8080/19445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184 Gerrit-Change-Number: 19445 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 07:52:11 +0000 Gerrit-HasComments: Yes
