Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19445 )
Change subject: KUDU-1945 Update auto incrementing counter during bootstrap ...................................................................... Patch Set 5: (5 comments) Looks good. Only a few nits. http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/integration-tests/auto_incrementing-itest.cc@338 PS5, Line 338: * nit: space around * http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/integration-tests/auto_incrementing-itest.cc@415 PS5, Line 415: int flag = 3; flag > 0; flag-- nit: int i = 0; i < 3; i++ http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/tablet/tablet.cc@446 PS5, Line 446: 32K should be a good start you remove the initial size 32K for mem http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/tablet/tablet.cc@466 PS5, Line 466: AIC AIC is not common abbreviation, not easy to understand. http://gerrit.cloudera.org:8080/#/c/19445/5/src/kudu/tablet/tablet.cc@466 PS5, Line 466: << add a space before << -- To view, visit http://gerrit.cloudera.org:8080/19445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184 Gerrit-Change-Number: 19445 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 23 Mar 2023 00:21:05 +0000 Gerrit-HasComments: Yes
