Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19640 )
Change subject: [Python] Support setting runtime flags in tests ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/19640/1/python/kudu/tests/common.py File python/kudu/tests/common.py: http://gerrit.cloudera.org:8080/#/c/19640/1/python/kudu/tests/common.py@133 PS1, Line 133: 1 Is it possible to introduce a constant with human-friendly name for this (e.g., similar to NUM_MASTER_SERVERS)? http://gerrit.cloudera.org:8080/#/c/19640/1/python/kudu/tests/common.py@149 PS1, Line 149: 2 ditto http://gerrit.cloudera.org:8080/#/c/19640/3/python/kudu/tests/common.py File python/kudu/tests/common.py: http://gerrit.cloudera.org:8080/#/c/19640/3/python/kudu/tests/common.py@131 PS3, Line 131: : nit: spacing http://gerrit.cloudera.org:8080/#/c/19640/3/python/kudu/tests/test_common.py File python/kudu/tests/test_common.py: http://gerrit.cloudera.org:8080/#/c/19640/3/python/kudu/tests/test_common.py@22 PS3, Line 22: class TestKuduTestBaseRuntimeFlags(KuduTestBase, CompatUnitTest): nit in this file: add space after a comma when separating arguments for a function call http://gerrit.cloudera.org:8080/#/c/19640/3/python/kudu/tests/test_common.py@47 PS3, Line 47: self.set_tserver_runtime_flag("tablet_apply_pool_overload_threshold_ms","a") Could you add a scenario to check how it fares on an attempt to set a value for a flag not marked with 'runtime' tag? -- To view, visit http://gerrit.cloudera.org:8080/19640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c381b207e2c0dbd700f94180e2311688be6f62c Gerrit-Change-Number: 19640 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 19:03:31 +0000 Gerrit-HasComments: Yes
