Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19640
to look at the new patch set (#5).
Change subject: [Python] Support setting runtime flags in tests
......................................................................
[Python] Support setting runtime flags in tests
Currently it is not streamlined, how to set Kudu master, tserver runtime
flags in Python tests. This patch adds
KuduTestBase.set_master_runtime_flag() and
KuduTestBase.set_tserver_runtime_flag() to tackle this issue.
The Python client uses the control shell interface to spin up a test
cluster. The available functionality is documented in tool.proto. The
above mentioned functions basically make a set_daemon_flag request. They
are almost identical, only the daemon id type is different(master:1,
tserver:2). If any error occurs during the setting of the flag, an
exception is raised, else nothing is returned. (see
ControlShellResponsePB)
Added a new test file for common.py. In case of successful setting of a
flag, currently there is not much to assert against. I did not find an
easy way to write tests for checking the presence of a newly set flag.
Negatives are asserted. (these indicate a proper turnaround from the
server)
Change-Id: I8c381b207e2c0dbd700f94180e2311688be6f62c
---
M python/kudu/tests/common.py
A python/kudu/tests/test_common.py
2 files changed, 109 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/19640/5
--
To view, visit http://gerrit.cloudera.org:8080/19640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c381b207e2c0dbd700f94180e2311688be6f62c
Gerrit-Change-Number: 19640
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
