Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18475 )
Change subject: jwt: plumb JWT into mini cluster ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/integration-tests/security-itest.cc@526 PS11, Line 526: cluster_opts_.num_tablet_servers = 0; nit: duplicated as line #517 http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/mini-cluster/external_mini_cluster.cc@85 PS11, Line 85: #include "kudu/util/jwt-util.h" nit: put this line in front of line #75 to keep alphabet order http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/mini-cluster/external_mini_cluster.cc@147 PS11, Line 147: , nit: move comma to the end of line #145 -- To view, visit http://gerrit.cloudera.org:8080/18475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653 Gerrit-Change-Number: 18475 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 27 Mar 2023 20:46:49 +0000 Gerrit-HasComments: Yes
