Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18475 )
Change subject: jwt: plumb JWT into mini cluster ...................................................................... Patch Set 14: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/integration-tests/security-itest.cc@515 PS11, Line 515: TEST_F(SecurityITest, TestJwtMiniCluster) { > that testcase is added in the following patch Ah, I missed that -- thanks for the clarification. http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/integration-tests/security-itest.cc@560 PS11, Line 560: > The error status returned here is a RuntimeError, I don't think that would That's right, but from the other side printing OK in case when s == Status::OK() doesn't provide more context either. Anyways, that sounds good enough to me. http://gerrit.cloudera.org:8080/#/c/18475/11/src/kudu/integration-tests/security-itest.cc@563 PS11, Line 563: shared_ptr<KuduClient> client; > Done Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653 Gerrit-Change-Number: 18475 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 28 Mar 2023 19:04:07 +0000 Gerrit-HasComments: Yes
