Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19445 )
Change subject: KUDU-1945 Update auto incrementing counter during bootstrap ...................................................................... Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/19445/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19445/6//COMMIT_MSG@21 PS6, Line 21: thi > this? Done http://gerrit.cloudera.org:8080/#/c/19445/6//COMMIT_MSG@21 PS6, Line 21: thi > missed addressing this one in PS7? Done http://gerrit.cloudera.org:8080/#/c/19445/6//COMMIT_MSG@23 PS6, Line 23: in-memory > nit: in-memory Done http://gerrit.cloudera.org:8080/#/c/19445/6//COMMIT_MSG@23 PS6, Line 23: in-memory > missing addressing this one in PS7? Done http://gerrit.cloudera.org:8080/#/c/19445/6//COMMIT_MSG@49 PS6, Line 49: > nit: keep an empty line between the commit description and 'Change-Id' line Done http://gerrit.cloudera.org:8080/#/c/19445/6/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19445/6/src/kudu/integration-tests/auto_incrementing-itest.cc@394 PS6, Line 394: ASSERT_EQ(results[i][k], results[i + 1][k]); : } > It would be great if you could add a comment into the code to explain why t Done http://gerrit.cloudera.org:8080/#/c/19445/7/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/19445/7/src/kudu/integration-tests/auto_incrementing-itest.cc@190 PS7, Line 190: unique_ptr<cluster::ExternalMiniCluster> cluster_; > Do we need to make sure resp.status_and_schema isn't empty? If you don't w Done http://gerrit.cloudera.org:8080/#/c/19445/7/src/kudu/integration-tests/auto_incrementing-itest.cc@281 PS7, Line 281: > nit: space around + Done -- To view, visit http://gerrit.cloudera.org:8080/19445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184 Gerrit-Change-Number: 19445 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 30 Mar 2023 20:01:08 +0000 Gerrit-HasComments: Yes
