Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19445 )
Change subject: KUDU-1945 Update auto incrementing counter during bootstrap ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/19445/12/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19445/12/src/kudu/tablet/tablet.cc@442 PS12, Line 442: " > nit: How about output the failed reason, i.e. s.ToString(). Done http://gerrit.cloudera.org:8080/#/c/19445/12/src/kudu/tablet/tablet.cc@496 PS12, Line 496: Stopwatch sw(Stopwatch::THIS_THREAD); > How about using LOG_TIMING* macros for this to simplify code? Done http://gerrit.cloudera.org:8080/#/c/19445/12/src/kudu/tablet/tablet.cc@518 PS12, Line 518: if (counter > auto_incrementing_counter_) { > Just curious, when counter <= auto_incrementing_counter_ ? It doesn't get updated. We want to update the counter to the highest value seen. counter <= auto_incrementing_counter_ might happen if the counter is already set to a high enough value from bootstrapping wal segments or if we have read a rowset with a higher value in previous iteration. -- To view, visit http://gerrit.cloudera.org:8080/19445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184 Gerrit-Change-Number: 19445 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 31 Mar 2023 17:08:23 +0000 Gerrit-HasComments: Yes
