Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19710 )
Change subject: [server] KUDU-1945 Fix bug in RowOperationsPBDecoder ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19710/1/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/19710/1/src/kudu/common/row_operations.cc@760 PS1, Line 760: int64_t counter = -1; : auto_incrementing_counter = auto_incrementing_counter ? auto_incrementing_counter : &counter; Does it make sense to move this up the chain into RowOperationsPBDecoder::DecodeOperations() in row_operations.cc, around line 735? That way it will be less branching logic per operation while comparing the 'auto_incrementing_counter' parameter with nullptr. -- To view, visit http://gerrit.cloudera.org:8080/19710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I540698ba346f9c6bed36607b222521b65c46018f Gerrit-Change-Number: 19710 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 Apr 2023 02:12:33 +0000 Gerrit-HasComments: Yes
