Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19710 )
Change subject: [server] KUDU-1945 Fix bug in RowOperationsPBDecoder ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19710/1/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/19710/1/src/kudu/common/row_operations.cc@760 PS1, Line 760: const ClientServerMapping& mapping, DecodedRowOperation* op, : int64_t* auto_incrementing_counter) { > Does it make sense to move this up the chain into RowOperationsPBDecoder::D Done http://gerrit.cloudera.org:8080/#/c/19710/2/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/19710/2/src/kudu/common/row_operations.cc@504 PS2, Line 504: g > nit: missing space to separate 'auto-incrementing' and 'column' Done -- To view, visit http://gerrit.cloudera.org:8080/19710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I540698ba346f9c6bed36607b222521b65c46018f Gerrit-Change-Number: 19710 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 Apr 2023 22:48:21 +0000 Gerrit-HasComments: Yes
