Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19709 )
Change subject: [jwt] Verify JWKS URL server TLS certificate by default ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19709/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19709/1//COMMIT_MSG@19 PS1, Line 19: tls nit: TLS http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/server/server_base.cc@281 PS1, Line 281: nit: extra space http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/server/server_base.cc@815 PS1, Line 815: nit: wrong indent http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/util/curl_util.cc File src/kudu/util/curl_util.cc: http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/util/curl_util.cc@168 PS1, Line 168: FLAGS_trusted_certificate_file EasyCurl class is common utility class. It could be used to download files from multiple sites in future. It's better to save certificate_file in member variable, not to access global flag variable directly. http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/util/jwt-util.cc@606 PS1, Line 606: jwks_ca_certificate it's unused -- To view, visit http://gerrit.cloudera.org:8080/19709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fd7b53d651786bbe57642dd14cd477055b80c78 Gerrit-Change-Number: 19709 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 07 Apr 2023 07:15:56 +0000 Gerrit-HasComments: Yes
