Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19709 )
Change subject: [jwt] Verify JWKS URL server TLS certificate by default ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19709/2/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/19709/2/src/kudu/integration-tests/security-itest.cc@642 PS2, Line 642: TestJwtMiniClusterWithUntrustedCert Except name, this unit test code looks same as TestJwtMiniClusterWithInvalidCert http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/util/curl_util.cc File src/kudu/util/curl_util.cc: http://gerrit.cloudera.org:8080/#/c/19709/1/src/kudu/util/curl_util.cc@168 PS1, Line 168: L_RETURN_NOT_OK(curl_easy_seto > We already use this flag to verify certificates when communicating with Ran We still use this flag, but pass the flag as parameter to this class to make this class generic. Impala also use this class, but Impala use different file name. -- To view, visit http://gerrit.cloudera.org:8080/19709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fd7b53d651786bbe57642dd14cd477055b80c78 Gerrit-Change-Number: 19709 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 11 Apr 2023 20:09:07 +0000 Gerrit-HasComments: Yes
