Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc File examples/cpp/non_unique_primary_key.cc: PS5: > Absolutely! I just wasn't sure on the positioning between supporting C++98 Yep, that works. Thank you! http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219 PS5, Line 219: FATAL > To run any of the C++ client apps, one has to provide the host address. Ah, I meant if (argc < 2) { KUDU_LOG(ERROR) << ...; return -1; } Does it make more sense to you now? I was just thinking that calling abort() is a bit strange when it's possible to exit gracefully with non-zero exit code to indicate an error. -- To view, visit http://gerrit.cloudera.org:8080/19690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec Gerrit-Change-Number: 19690 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 13 Apr 2023 05:14:36 +0000 Gerrit-HasComments: Yes
