Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK ...................................................................... Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc File examples/cpp/non_unique_primary_key.cc: http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@116 PS3, Line 116: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@137 PS3, Line 137: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@178 PS3, Line 178: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@255 PS3, Line 255: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@268 PS3, Line 268: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@275 PS3, Line 275: Update row(s > nit: the predicate is built on non unique primary key and non PK column, mu Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@286 PS3, Line 286: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@290 PS3, Line 290: Update row(s) > nit: the predicate is built on non unique primary key, multiple rows could Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@302 PS3, Line 302: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@323 PS3, Line 323: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@330 PS3, Line 330: Delete row(s) > nit: the predicate is built on non unique primary key and non PK column, mu Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@340 PS3, Line 340: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@344 PS3, Line 344: Delete row(s) > nit: Delete rows Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@354 PS3, Line 354: * > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@362 PS3, Line 362: row > nit: a Done -- To view, visit http://gerrit.cloudera.org:8080/19690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec Gerrit-Change-Number: 19690 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 08 Apr 2023 16:21:58 +0000 Gerrit-HasComments: Yes
