Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [tablet] GC ancient, fully deleted rowsets witout live row count stats ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19670/7/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: http://gerrit.cloudera.org:8080/#/c/19670/7/src/kudu/tablet/diskrowset.h@a383 PS7, Line 383: > Just for tidy test, the 'final' is redundant since the function is already Perhaps it's worth to keep 'final', but drop 'override' instead? IIUC, the idea was to make sure CountRows() isn't overridden in derived classes: https://en.cppreference.com/w/cpp/language/final -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 7 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 15 Apr 2023 05:23:18 +0000 Gerrit-HasComments: Yes
