Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 )
Change subject: [tablet] GC ancient, fully deleted rowsets witout live row count stats ...................................................................... Patch Set 14: (8 comments) http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc File src/kudu/tablet/diskrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@778 PS14, Line 778: // The rowset's live rows count from different way should equal if there is : // no DMS exist. nit: The rowset's live row count should be equal when there are no live row count stats available if no DMS exists. http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@790 PS14, Line 790: without DMS exist nit: if no DMS exists. http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@790 PS14, Line 790: live rows count nit: live row count Here and everywhere else. http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@806 PS14, Line 806: nit: be http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@806 PS14, Line 806: there is : // no DMS exist. nit: if no DMS exists. http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@818 PS14, Line 818: DMS nit: a DMS http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@824 PS14, Line 824: dms nit: DMS http://gerrit.cloudera.org:8080/#/c/19670/14/src/kudu/tablet/diskrowset-test.cc@828 PS14, Line 828: there is DMS exist nit: if a DMS exists. -- To view, visit http://gerrit.cloudera.org:8080/19670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdff107b8b07cbd56f47f296a93f4bcfbf56b41 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 14 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 21 Apr 2023 18:46:26 +0000 Gerrit-HasComments: Yes
