Hello Kudu Jenkins, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19847

to look at the new patch set (#4).

Change subject: KUDU-3475: Update to the most recent sse2neon.h
......................................................................

KUDU-3475: Update to the most recent sse2neon.h

ARM builds on Ubuntu 20.04 hit an error about the
redeclaration of vld1q_u8_x4 in sse2neon.h. This is
because Ubuntu 20.04 uses GCC 9.4, which has its own
definition of vld1q_u8_x4, and the preprocessor checks
in the current sse2neon.h don't account for this
correctly.

Newer versions of sse2neon.h have namespaced their
macros so that vld1q_u8_x4 is no longer used and
improved the checks for GCC versions. This updates
sse2neon.h to the latest available (commithash b7417bc).

sse2neon.h has a large number of lint issues related
to style (whitespace/braces, readability/casting) and
none look like real correctness issues, so this exempts
sse2neon.h from lint.

Testing:
 - Built Kudu on Ubuntu 20.04 ARM64 and Ubuntu 18.04 ARM64

Change-Id: Id156a0b2c3984f9cb1032fa7747d7f9ed76c1f8c
---
M build-support/lint.sh
M src/kudu/util/sse2neon.h
2 files changed, 8,813 insertions(+), 3,028 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/19847/4
--
To view, visit http://gerrit.cloudera.org:8080/19847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id156a0b2c3984f9cb1032fa7747d7f9ed76c1f8c
Gerrit-Change-Number: 19847
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)

Reply via email to