Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19847 )
Change subject: KUDU-3475: Update to the most recent sse2neon.h ...................................................................... Patch Set 4: > > > Patch Set 4: > > > > > > Thanks to the contribution! > > > > > > But I'm curious why not introduce it as a thirdparty? > > > > > > It is from https://github.com/DLTcollab/sse2neon, thanks to it's > > license is MIT, but I don't think introduce it's source code to > > Kudu directly is a good idea. > > If we want to rework it to make sse2neon.h come from thirdparty, we > can. sse2neon.h was checked in to Kudu as part of > https://github.com/apache/kudu/commit/74459bd1b3ba311360a8b832873d9e3273dfc83a, > so this change was upgrading it in place. If we move it to > thirdparty, we'll need to update the existing #includes. I guess it's better to keep this in the main tree in the scope of this patch. If necessary, we can move this into the thirdparty in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/19847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id156a0b2c3984f9cb1032fa7747d7f9ed76c1f8c Gerrit-Change-Number: 19847 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 17 May 2023 03:26:07 +0000 Gerrit-HasComments: No
