Hello Kudu Jenkins, KeDeng,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19915

to look at the new patch set (#3).

Change subject: [ut] Add '--log_cleanup_interval_sec' flag and speedup an unit 
test
......................................................................

[ut] Add '--log_cleanup_interval_sec' flag and speedup an unit test

LogRollingITest.TestLogCleanupOnStartup is a little slow, it takes 116s or so.

This patch try to speed up this test and avoid coredump when flushing logs
asynchronously. Adding '--log_cleanup_interval_sec' flag replaces the magic
number kWait(60s), set it 6s in the unit test. It takes half(56s) of
original time(116s). This new flag can be changed at runtime if needed.

Independent related works before this patch:
1. https://gerrit.cloudera.org/c/19842/, this patch has merged and solved
this unsteady unit test. This is an original aim of this patch.
2. https://gerrit.cloudera.org/c/19871/ by KeDeng, this patch has same idea
with this patch, it's abandoned by KeDeng because of ut may be fail. By
KeDeng' reminder, This patch fixed this potential problem.

Change-Id: Ib2be9f88c5d47bc889a4711f5aa2143b8288ba60
---
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/server/server_base.cc
2 files changed, 18 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19915/3
--
To view, visit http://gerrit.cloudera.org:8080/19915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2be9f88c5d47bc889a4711f5aa2143b8288ba60
Gerrit-Change-Number: 19915
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <[email protected]>

Reply via email to