Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19915 )
Change subject: [ut] Add '--log_cleanup_interval_sec' flag and speedup an unit test ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/19915/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19915/3//COMMIT_MSG@9 PS3, Line 9: TestLogCleanupOnStartup is a little slow Is slowness applicable to only this test or this can be done for some other tests as well? http://gerrit.cloudera.org:8080/#/c/19915/3//COMMIT_MSG@11 PS3, Line 11: try nit: tries http://gerrit.cloudera.org:8080/#/c/19915/3/src/kudu/integration-tests/log-rolling-itest.cc File src/kudu/integration-tests/log-rolling-itest.cc: http://gerrit.cloudera.org:8080/#/c/19915/3/src/kudu/integration-tests/log-rolling-itest.cc@65 PS3, Line 65: at nit: at -> in http://gerrit.cloudera.org:8080/#/c/19915/3/src/kudu/integration-tests/log-rolling-itest.cc@65 PS3, Line 65: by searching : // 'The logbufsecs default is 30 seconds which is a bit too long'. nit: You can remove this. No need to mention this. Text may change in future and this statement for search criterion may not be applicable anymore. http://gerrit.cloudera.org:8080/#/c/19915/3/src/kudu/integration-tests/log-rolling-itest.cc@70 PS3, Line 70: log_cleanup_interval_sec = 6 Just for my understanding as I am not clear on how this works. If we keep on increasing this further, does ut time taken for completion also increase? -- To view, visit http://gerrit.cloudera.org:8080/19915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2be9f88c5d47bc889a4711f5aa2143b8288ba60 Gerrit-Change-Number: 19915 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 21 Jul 2023 17:50:54 +0000 Gerrit-HasComments: Yes
