Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19909 )
Change subject: [duplication] KUDU-3290 add thirdparty libraries ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19909/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19909/1//COMMIT_MSG@26 PS1, Line 26: During this progressing, plans maybe adjust according to advices. I guess the very first step should be publishing a design document and asking for feedback at [email protected]. The information in KUDU-3290 JIRA item provides some context, but it doesn't constitute a proper design document since it lacks important details and it's hard to understand what requirements are and what's the exact plan to achieve that. Also, JIRA isn't a perfect venue for discussions and feedback, and a shared document (e.g., in Google Docs) would be much better in that regard. Adding new components to 3rd-party without actually using them isn't a good idea. It just adds to the compilation time, and that's it. It's not a big deal, but we have already added rocksdb, but the rest of the patches in that context is blocked on reviews. I think it's totally fine to keep this patch in your repo, and build on top of that, revving this patch as well if necessary. So, eventually there will be a stack of patches to submit. At least, I'd like to see that the design document is published, gets enough feedback. Once the design solidifies, then we should consider pushing this patch into the Kudu upstream repo. Does this make sense? -- To view, visit http://gerrit.cloudera.org:8080/19909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbd5738a61d2521b363c628f88e3699879920a49 Gerrit-Change-Number: 19909 Gerrit-PatchSet: 1 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 May 2023 22:59:06 +0000 Gerrit-HasComments: Yes
