Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19909 )
Change subject: [duplication] KUDU-3290 Support write ops to kafka with kafka client ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/integration-tests/single_broker_kafka.h File src/kudu/integration-tests/single_broker_kafka.h: http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/integration-tests/single_broker_kafka.h@39 PS3, Line 39: static const int kZookeeperSessionTimeoutS = 10; > warning: method 'InitKafka' can be made const [readability-make-member-func Done http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/integration-tests/single_broker_kafka.h@48 PS3, Line 48: > warning: method 'StartKafka' can be made const [readability-make-member-fun Done http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/integration-tests/single_broker_kafka.h@57 PS3, Line 57: string command = Substitute("$0 start $1", command_, offset_port_); > warning: method 'StopKafka' can be made const [readability-make-member-func Done http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/integration-tests/single_broker_kafka.h@66 PS3, Line 66: } > warning: method 'DestroyKafka' can be made const [readability-make-member-f Done http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/19909/3/src/kudu/tablet/tablet_replica.cc@199 PS3, Line 199: > error: constructor for 'kudu::tablet::TabletReplica' must explicitly initia Done -- To view, visit http://gerrit.cloudera.org:8080/19909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbd5738a61d2521b363c628f88e3699879920a49 Gerrit-Change-Number: 19909 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 13:32:37 +0000 Gerrit-HasComments: Yes
