Hello Mahesh Reddy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19944
to review the following change.
Change subject: KUDU-3418 Improve hole punching error message description.
......................................................................
KUDU-3418 Improve hole punching error message description.
Kudu LBM relies on hole punching support from filesystem.
However, it is possible that even with supported kernel version
and fileystem type, hole punching feature may not work.
Hole punching uses fallocate system call to do its job.
But it is evident from fallocate system call implementation of
ext4, that encrypted inodes are not supported.
Refer: https://elixir.bootlin.com/linux/latest/source/fs/ext4/extents.c#L4685
The same description is added to kHolePunchErrorMsg used by
CheckHolePunch method that checks for hole punching support.
Change-Id: If87401012052508b9cdf394cd33dc32fb58659d4
Reviewed-on: http://gerrit.cloudera.org:8080/19525
Reviewed-by: Mahesh Reddy <[email protected]>
Reviewed-by: Yingchun Lai <[email protected]>
Tested-by: Yingchun Lai <[email protected]>
---
M src/kudu/fs/dir_util.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/19944/1
--
To view, visit http://gerrit.cloudera.org:8080/19944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If87401012052508b9cdf394cd33dc32fb58659d4
Gerrit-Change-Number: 19944
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
