Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19944 )
Change subject: KUDU-3418 Improve hole punching error message description. ...................................................................... KUDU-3418 Improve hole punching error message description. Kudu LBM relies on hole punching support from filesystem. However, it is possible that even with supported kernel version and fileystem type, hole punching feature may not work. Hole punching uses fallocate system call to do its job. But it is evident from fallocate system call implementation of ext4, that encrypted inodes are not supported. Refer: https://elixir.bootlin.com/linux/latest/source/fs/ext4/extents.c#L4685 The same description is added to kHolePunchErrorMsg used by CheckHolePunch method that checks for hole punching support. Change-Id: If87401012052508b9cdf394cd33dc32fb58659d4 Reviewed-on: http://gerrit.cloudera.org:8080/19525 Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> Tested-by: Yingchun Lai <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/19944 Tested-by: Kudu Jenkins Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/fs/dir_util.cc 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, but someone else must approve Ashwani Raina: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: If87401012052508b9cdf394cd33dc32fb58659d4 Gerrit-Change-Number: 19944 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
