Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19910 )
Change subject: [jwt] switching JWT verification to KeyBasedJwtVerifier ...................................................................... Patch Set 9: > I don't think a new patch is necessary as the patch is reusing > already present logic. The affected already existing tests were > updated to reflect the new way it works. Yeah, but this patch claims to address the issue when masters failed to start because of some issue with JWKS servers. That hasn't been covered in existing tests. I don't think that I can give +2 for this patch without such a test. -- To view, visit http://gerrit.cloudera.org:8080/19910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f166807bfcf7051bda7843e186eacfbe379eba Gerrit-Change-Number: 19910 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 31 May 2023 19:58:29 +0000 Gerrit-HasComments: No
