Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19910 )
Change subject: [jwt] switching JWT verification to KeyBasedJwtVerifier ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/19910/13/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/19910/13/src/kudu/integration-tests/security-itest.cc@782 PS13, Line 782: const auto* const kValidAc > Any expectations for the status here? Yeah, this wasn't properly finished. I added a new option to make it possible to not start the jwks and thus providing a bogus url, so we can make sure that the cluster itself starts, however JWT verification is not possible, due to not being able to acquire the JWKS. http://gerrit.cloudera.org:8080/#/c/19910/13/src/kudu/util/jwt-util.h File src/kudu/util/jwt-util.h: http://gerrit.cloudera.org:8080/#/c/19910/13/src/kudu/util/jwt-util.h@144 PS13, Line 144: > I could not find where it's set TRUE in PS13. Maybe, I'm missing something it wasn't needed in the end and it was just left in on accident, thanks for catching it. -- To view, visit http://gerrit.cloudera.org:8080/19910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f166807bfcf7051bda7843e186eacfbe379eba Gerrit-Change-Number: 19910 Gerrit-PatchSet: 14 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 12:22:19 +0000 Gerrit-HasComments: Yes
