Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20061 )

Change subject: [server] KUDU-1945 Auto_incrementing column Upsert support
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20061/2/src/kudu/common/row_operations.cc
File src/kudu/common/row_operations.cc:

http://gerrit.cloudera.org:8080/#/c/20061/2/src/kudu/common/row_operations.cc@490
PS2, Line 490: "invalid auto-incrementing "
             :                                                                  
    "column value"
> Since we are in the if block, maybe we could give more detailed error messa
Done


http://gerrit.cloudera.org:8080/#/c/20061/2/src/kudu/common/row_operations.cc@505
PS2, Line 505: "auto-incrementing column is incorrectly set"
> Same thing as above, maybe we can give more detailed error message, for exa
Done



--
To view, visit http://gerrit.cloudera.org:8080/20061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cc4d80f77c165452572948f68c76fc70394d47
Gerrit-Change-Number: 20061
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Fri, 16 Jun 2023 18:04:55 +0000
Gerrit-HasComments: Yes

Reply via email to