Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20061 )
Change subject: [server] KUDU-1945 Auto_incrementing column UPSERT support ...................................................................... Patch Set 8: Code-Review+1 (4 comments) Overall looks good, just a few nits and a request to add a few more test sub-cases. http://gerrit.cloudera.org:8080/#/c/20061/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20061/6//COMMIT_MSG@14 PS6, Line 14: After this patch below is the different operation support for : tables with auto-incrementing columns from the Kudu client. This is hard to parse, please update this to be more readable. http://gerrit.cloudera.org:8080/#/c/20061/6//COMMIT_MSG@23 PS6, Line 23: implemention implementation http://gerrit.cloudera.org:8080/#/c/20061/8/src/kudu/tablet/tablet_auto_incrementing-test.cc File src/kudu/tablet/tablet_auto_incrementing-test.cc: http://gerrit.cloudera.org:8080/#/c/20061/8/src/kudu/tablet/tablet_auto_incrementing-test.cc@19 PS8, Line 19: nit: remove empty line 19 http://gerrit.cloudera.org:8080/#/c/20061/8/src/kudu/tablet/tablet_auto_incrementing-test.cc@189 PS8, Line 189: { : unique_ptr<KuduPartialRow> row(new KuduPartialRow(&client_schema_)); : ASSERT_OK(row->SetInt64(0, INT64_MAX)); : ASSERT_OK(row->SetInt32(1, 1337)); : ASSERT_OK(writer_->Upsert(*row)); : } Thank you for adding these negative scenarios! I'm curious: what's the expected behavior if after this UPSERT with INT64_MAX for the auto-incrementing column's value another UPSERT attempted with value that's not yet present in the table? I guess that should succeed, right? Also, attempting another UPSERT with INT64_MAX after failed INSERT should succeed as well, correct? Does it make sense to add a sub-case for that as well? I guess it's important to splice them like the following to test how the counter is updated at the server side: UPSERT(INT64_MAX) UPSERT(not-yet-existing-value-for-auto-increment-column) INSERT UPSERT(INT64_MAX) -- To view, visit http://gerrit.cloudera.org:8080/20061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5cc4d80f77c165452572948f68c76fc70394d47 Gerrit-Change-Number: 20061 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 06:12:52 +0000 Gerrit-HasComments: Yes
